CesiumGS/cesium

GeoJsonDataSource sourceUri parameter isn't used

Open

#6,108 opened on Jan 10, 2018

View on GitHubContributor guide
 (2 comments) (0 reactions) (1 assignee)JavaScript (3,324 forks)batch import
FCFgood first issue

Repository metrics

Stars
 (11,758 stars)
PR merge metrics
 (Avg merge 15d 12h) (23 merged PRs in 30d)

Description

The GeoJsonDataSource.load() has a sourceUri parameter that isn't used to resolve relative links as GeoJSON files don't have any. It is used to get the datasource name, which can be set on creation of the datasource. This can be removed.

Contributor guide

Research direction
Investigate the GeoJsonDataSource.load() method to confirm the sourceUri parameter is unused and plan its removal.
Tech stack
javascript
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85