Byron/trash-rs

[feat] Map Windows errors

Open

#96 opened on Jan 10, 2024

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Rust (40 forks)auto 404
enhancementhelp wanted

Repository metrics

Stars
 (247 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

It appears that all windows::core::Error's are mapped to trash::Error::Unknown (code here). Is it possible to use the error code (ref) to map at least some of the more common errors to the corresponding trash::Error variant?

e.g. codes 2 and 3 could map to trash::Error::FileSystem with an error kind of std::io::ErrorKind::NotFound.

Another option could allow for the Unknown variant to also accept an optional error code, but that doesn't feel like the correct way to go about it.

Happy to give implementation a shot if it seems like a good idea.

Contributor guide

Research direction
Map Windows error codes to `trash::Error` variants by inspecting the error code from `windows::core::Error` and matching against known system error codes.
Tech stack
rust
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustWindows
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50