Azure-Samples/contoso-real-estate

[Chore] Recommend updating appservice.bicep to latest azure-dev files

Open

#460 opened on Apr 7, 2024

View on GitHubContributor guide
 (1 comment) (0 reactions) (1 assignee)JavaScript (534 forks)auto 404
good first issuepriority: P0scope: infra

Repository metrics

Stars
 (973 stars)
PR merge metrics
 (PR metrics pending)

Description

In the original version of appservice.bicep, appSettings was not wrapped with an @secure decorator, so if a developer put any secrets in their app settings, it would leak into deployment outputs and cause a security alert. The latest version now has the secure decorator.

I noticed this repo is using the old version, so I recommend upgrading if you can.

You can git clone https://github.com/azure/azure-dev and then cp like this:

cp ../azure-dev/templates/common/infra/bicep/core/host/* infra/core/host/.

Or only cp app service files if you don't use other hosts:

cp ../azure-dev/templates/common/infra/bicep/core/host/appservice* infra/core/host/.

Then run azd up to make sure all still works.

Contributor guide

Research direction
Clone the azure dev repository and copy the latest appservice.bicep files into the current repo's infra/core/host directory. Then run 'azd up' to verify the deployment still works.
Tech stack
None
Domain
devopsinfrastructurecloud
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitAzure CLIAzure Developer CLI
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80