Automattic/jetpack

Shortcode Embeds: add embed_oembed_html filter to all shortcodes

Open

#1,571 opened on Jan 30, 2015

View on GitHubContributor guide
 (8 comments) (4 reactions) (0 assignees)PHP (877 forks)user submission
EnhancementGood For CommunityHacktoberfest[Feature] Shortcodes / Embeds[Pri] Low[Type] Good First Bug

Repository metrics

Stars
 (1,808 stars)
PR merge metrics
 (Avg merge 4d 5h) (645 merged PRs in 30d)

Description

Hi,

I've noticed that the filter embed_oembed_html can not be counted on because as soon as Jetpack's Shortcode Embeds is activated, this filter is no longer there even if the new shortcode [youtube](or similar) is not used.

Please either add this filter like it was originally implemented in WP core -OR- please do not override the oembed that occurs when simply pasting a Youtube or other media host URL and limit yourself to the [youtube] and similar added shortcodes.

Hope that explanation was not too confusing ;)

Thanks!

Contributor guide

Research direction
Examine the Shortcode Embeds module in Jetpack to find where oEmbed output is generated and where the embed oembed html filter should be applied. Look for the shortcode handlers for YouTube and other providers and ensure the filter is called.
Tech stack
php
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPWordPress plugin development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60