Automattic/jetpack

Sharing: make sure the "More" button label match what will be displayed on the frontend

Open

#1,390 opened on Dec 10, 2014

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)PHP (877 forks)user submission
EnhancementHacktoberfest[Feature] Sharing[Type] Good First Bug

Repository metrics

Stars
 (1,808 stars)
PR merge metrics
 (Avg merge 4d 5h) (645 merged PRs in 30d)

Description

Steps to reproduce:

  1. Go to Settings > Sharing
  2. Place sharing buttons in the hidden sharing area: screen shot 2014-12-10 at 8 42 34 am
    • In the preview, the button uses "More" as a label
  3. Save your changes, visit your site: screen shot 2014-12-10 at 8 43 24 am

It'd be nice if the admin preview was adjusted to match what will be displayed on the frontend.

Contributor guide

Research direction
Compare the label used in the admin preview with the frontend label in the sharing module code.
Tech stack
php
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
WordPress
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70