AbandonTech/abandonauth

Enforce schema in Callback URIs and use full URI in abandon auth UI

Open

#62 opened on Nov 5, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (2 forks)auto 404
backendenhancementgood first issuehelp wanted

Repository metrics

Stars
 (4 stars)
PR merge metrics
 (PR metrics pending)

Description

Summary

Callback URIs can be set to any arbitrary value, including relative paths or just nonsense. Currently the AbandonAuth UI for developer dashboards uses a relative path for the callback URI. This should be changed to use the full URL in the specific environment. I.e in production we should be using auth.abandontech.cloud/ui, in dev it should use localhost:{port}/ui where port is the actual port the application is being locally deployed with.

Acceptance Criteria

Callback URIs have validation either in the database, Pydantic models, or both that forces them to be in the form of a valid URI, therefore disallowing relative paths or random strings. The AbandonAuth UI must also use the new, correct format for its own redirect to the AbandonAuth login page.

Contributor guide

Research direction
Add validation for callback URIs in Pydantic models to ensure they are valid URIs, and update the AbandonAuth UI to use the full environment specific URL instead of a relative path.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonPydantic
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75