4paradigm/OpenMLDB

udf test for `unix_timestamp("")` might fail

Open

#2,998 opened on Jan 30, 2023

View on GitHubContributor guide
 (5 comments) (0 reactions) (2 assignees)C++ (329 forks)github user discovery
buggood first issuetest

Repository metrics

Stars
 (1,687 stars)
PR merge metrics
 (Avg merge 25d 1h) (5 merged PRs in 30d)

Description

/home/runner/work/OpenMLDB/OpenMLDB/hybridse/src/udf/udf_test.h:172: Failure
Expected equality of these values:
  expect
    Which is: Nullable{value=1674015278, type=int64}
  output
    Which is: Nullable{value=1674015279, type=int64}

refer https://github.com/4paradigm/OpenMLDB/actions/runs/3945482097/jobs/6752411020#step:7:21561

Fail might happen due to slow execution.

Contributor guide

Research direction
Investigate the unix timestamp UDF test for empty string input. The test expects a specific timestamp but fails when execution is slow, causing a one second difference. Consider adding tolerance for time sensitive tests or mocking the current time.
Tech stack
None
Domain
backenddatabasetesting
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Google Test
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30