123ishaTest/ludiek

Reconsider `amount` for input and output

Open

#84 opened on Aug 19, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (4 forks)auto 404
good first issuehelp wanted

Repository metrics

Stars
 (12 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

#83 introduced input and output. While very useful, the amount property can sometimes be awkward as it doesn't make sense for all resources (e.g. AchievementOutput)

Consider refactoring it to also implement a getAmount() which defaults to input.amount if it's available and if not errors. Basically ensure that one is implemented. Can also already be done at engine construction

Contributor guide

Research direction
Examine the input and output classes introduced in PR #83, understand how `amount` is currently used, and implement a `getAmount()` method that falls back to input.amount or throws an error. Ensure the refactoring maintains backward compatibility.
Tech stack
typescript
Domain
game dev
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55